Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for supportedTypes from basic-card #13859

Merged
merged 4 commits into from
Nov 2, 2018
Merged

Remove tests for supportedTypes from basic-card #13859

merged 4 commits into from
Nov 2, 2018

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Nov 1, 2018 •
edited
Loading

@marcoscaceres marcoscaceres mentioned this pull request Nov 1, 2018
Merged
7 tasks
rsolomakhin
rsolomakhin approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of wording comments.

payment-method-basic-card/empty-data-manual.https.html Outdated Show resolved Hide resolved
payment-method-basic-card/empty-data-manual.https.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Contributor Author

Ooooh! I like the new suggest change thingy! That's neat!

@marcoscaceres marcoscaceres merged commit fb15e14 into master Nov 2, 2018
@marcoscaceres marcoscaceres deleted the supportedType_basic_card branch November 2, 2018 00:06
@jugglinmike jugglinmike mentioned this pull request Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsolomakhin rsolomakhin rsolomakhin approved these changes

@mnoorenberghe mnoorenberghe Awaiting requested review from mnoorenberghe

Assignees
No one assigned
Labels
payment-method-basic-card wg-payments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoscaceres @rsolomakhin @wpt-pr-bot